View Single Post
  #13  
Old January 10th, 2021, 05:54 PM
ErikCumps's Avatar

ErikCumps ErikCumps is offline
Corporal
 
Join Date: Jan 2019
Location: Leuven, Belgium
Posts: 70
Thanks: 27
Thanked 89 Times in 29 Posts
ErikCumps is on a distinguished road
Default Re: War Cabinet 0.8.2 is available!

Quote:
Originally Posted by KAreil View Post
No worries.
I'm in Technical Support myself and I was mentally preparing a list of tests I'd do now to narrow down the issue.

Looking forward to the new version, I wouldn't mind if you shared the details of the bug.

Thanks a lot for your outstanding work!
War Cabinet 0.8.3, which fixes these bugs, has just been released!.

Issue #13, the incomplete preferences error you get when the Default setting in the warcab.ini file
is (-1), was just a leftover behavior of before the game config preference changes.

Issue #14, well, that was embarrasing, as I said.

One of the changes for War Cabinet 0.8.2 where some new error dialog boxes to show when trying to add
a savegame to a dossier.

Dossier files keep track of the original OOB folder when the first savegame was added to it. (this is actually
the OOB folder of the selected game config at the time the dossier was created)


By tracking this OOB folder, War Cabinet can always know where it should look for additional savegames
to add to the dossier, even when the game configs in the preferences have changed in the meantime.

But, if the corresponding game folder matching the OOB folder recorded in a dossier can not be found, it
becomes impossible to list savegames to add to the dossier and an error dialog box must be shown to
explain this.

Of course, new error dialog boxes need testing, and testing needs either an actual error condition or a
simulation of the error condition in the code.

Guess what, I added some debug code to simulate the error condition. The error was simulated, the dialog
box was shown, everything was good. Except... I forgot to remove the code that simulates the error!

And so, even if the error condition wasn't there, even if everything was fine, the debug code was executed
anyway, an error condition was simulated and an error dialog box was shown in all cases.

Erik
Reply With Quote
The Following User Says Thank You to ErikCumps For This Useful Post: