ritual site search bug/feature request

[DrPraetorious]

All ritual magic happens before battles, changing that is a non-starter. Site searching spells are a minor point to make them an exception to the ordinary order of turn resolution.

As far as I can tell, what it does now is: it crawls through the list in order until it finds a site that isn't being targeted and that has none-zip-zero search points in that magic path.

Now, on the one hand, you do *eventually* want to cast Haurspex on provinces that got only a nature-1 search. OTOH, it would be a major pain if the spell searched those provinces *first*. So if you're going to change the way it works at all, you should have a prioritization algorithm.

[Gandalf Parker]

Anything could be made more efficient but sometimes I think they cut back on all the possible efficient code for hosting time.

Its too bad though. I would rather that ALL of the efficient code was put in. I dont really care how long a hosting takes.

[thejeff]

You may be misunderstanding the problem. It's not that the province is searched and then taken on the turn the spell is cast. That's expected and can occur casting the spells manually.
It's that the automated caster can target a province that is then taken, leaving the caster with orders to cast on a province you no longer own. This can't be duplicated manually, since you can't select that province.

It could be fixed with a quick cleanup check after the battle phase to clear out any monthly orders no longer valid. (Or preferably re-target to a now valid province.)

Actually a better fix would be to handle all of next months monthly orders later in the sequence. This would let you use this months gem income on monthly spells.


As for the current order, it looks to me like you are right about the intent, except that it skips some provinces, often, but not always and not all, capitols.

[DrPraetorious]

Ah, you're right. I was 100% mistaken and thejeff makes a good point. An extra phase for autogenerated orders (after gem income) would probably be a good idea.